Skip to content

[ET-VK][ez] Fix erroneous cherry-pick bot merge #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

[ET-VK][ez] Fix erroneous cherry-pick bot merge #13512

merged 1 commit into from
Aug 19, 2025

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 19, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:
It seems #13474 was not merged correctly via the cherry pick bot. This PR manually syncs internal and fbcode.

@SS-JIA
[ET-VK][ez] Fix erroneous manual merge
d069040 
Summary:
It seems #13474 was not merged correctly via the cherry pick bot. This PR manually syncs internal and fbcode.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13512

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 5 Pending

As of commit d069040 with merge base 85e5b6e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2025
SS-JIA added a commit that referenced this pull request Aug 19, 2025
@SS-JIA
[ET-VK][ez] Fix erroneous manual merge
d7ef0f0 
Summary:
It seems #13474 was not merged correctly via the cherry pick bot. This PR manually syncs internal and fbcode.

ghstack-source-id: fe9c81a
Pull Request resolved: #13512
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA SS-JIA changed the title [ET-VK][ez] Fix erroneous manual merge [ET-VK][ez] Fix erroneous cherry-pick bot merge Aug 19, 2025
@SS-JIA SS-JIA changed the base branch from gh/SS-JIA/294/base to main August 19, 2025 11:52
SS-JIA
SS-JIA commented Aug 19, 2025
View reviewed changes
backends/vulkan/runtime/graph/ComputeGraph.cpp
}
}

void ComputeGraph::prepare_pipelines() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow this function got redefined

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Aug 19, 2025 •
edited
Loading

All test failures are unrelated.

Unique failure 1:

      [100%] Linking CXX static library libtokenizers.a
      [100%] Built target tokenizers
      [100%] Building CXX object CMakeFiles/pytorch_tokenizers_cpp.dir/src/python_bindings.cpp.o
      [100%] Linking CXX shared module /pytorch/executorch/extension/llm/tokenizers/build/lib.linux-x86_64-cpython-310/pytorch_tokenizers/pytorch_tokenizers_cpp.cpython-310-x86_64-linux-gnu.so
      /usr/bin/ld: third-party/pcre2/libpcre2-8.a(pcre2_compile.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC
      /usr/bin/ld: failed to set dynamic section sizes: bad value
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
      gmake[3]: *** [CMakeFiles/pytorch_tokenizers_cpp.dir/build.make:171: /pytorch/executorch/extension/llm/tokenizers/build/lib.linux-x86_64-cpython-310/pytorch_tokenizers/pytorch_tokenizers_cpp.cpython-310-x86_64-linux-gnu.so] Error 1
      gmake[2]: *** [CMakeFiles/Makefile2:1228: CMakeFiles/pytorch_tokenizers_cpp.dir/all] Error 2
      gmake[1]: *** [CMakeFiles/Makefile2:1235: CMakeFiles/pytorch_tokenizers_cpp.dir/rule] Error 2
      gmake: *** [Makefile:215: pytorch_tokenizers_cpp] Error 2

Unique failure 2:

      CMake Error at /opt/conda/envs/py_3.10/lib/python3.10/site-packages/cmake/data/share/cmake-3.31/Modules/CMakeTestCCompiler.cmake:67 (message):
        The C compiler
      
          "/opt/cache/bin/cc"
      
        is not able to compile a simple test program.
      
        It fails with the following output:
      
          Change Dir: '/pytorch/executorch/extension/llm/tokenizers/build/temp.linux-x86_64-cpython-310/pytorch_tokenizers_cpp/CMakeFiles/CMakeScratch/TryCompile-YqXSLg'
      
          Run Build Command(s): /opt/conda/envs/py_3.10/lib/python3.10/site-packages/cmake/data/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f Makefile cmTC_1858b/fast
          /usr/bin/gmake  -f CMakeFiles/cmTC_1858b.dir/build.make CMakeFiles/cmTC_1858b.dir/build
          gmake[1]: Entering directory '/pytorch/executorch/extension/llm/tokenizers/build/temp.linux-x86_64-cpython-310/pytorch_tokenizers_cpp/CMakeFiles/CMakeScratch/TryCompile-YqXSLg'
          Building C object CMakeFiles/cmTC_1858b.dir/testCCompiler.c.o
          /opt/cache/bin/cc    -o CMakeFiles/cmTC_1858b.dir/testCCompiler.c.o -c /pytorch/executorch/extension/llm/tokenizers/build/temp.linux-x86_64-cpython-310/pytorch_tokenizers_cpp/CMakeFiles/CMakeScratch/TryCompile-YqXSLg/testCCompiler.c
          sccache: error: Server startup failed: cache storage failed to read: Unexpected (temporary) at stat
      
          Context:
             uri: https://s3.us-east-1.amazonaws.com/ossci-compiler-cache-circleci-v2/executorch/.sccache_check
             response: Parts { status: 503, version: HTTP/1.1, headers: {"x-amz-request-id": "40GXAGNVPX97T447", "x-amz-id-2": "5pZez+Dt85PjU0JmEWOJYwDDxdQC6qQkstKGclm9QwrbsSkeoTVUfi0Toak6Et4VYxpunIZt3W4=", "content-type": "application/xml", "transfer-encoding": "chunked", "date": "Tue, 19 Aug 2025 11:54:05 GMT", "connection": "close", "server": "AmazonS3"} }
             service: s3
             path: .sccache_check
      
          Backtrace:
             0: <unknown>
             1: <unknown>
             2: <unknown>
             3: <unknown>
             4: <unknown>
             5: <unknown>
             6: <unknown>
             7: <unknown>
             8: <unknown>
             9: <unknown>
            10: <unknown>
            11: <unknown>
            12: <unknown>
            13: __libc_start_main
            14: <unknown>
      
      
          Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information
          gmake[1]: *** [CMakeFiles/cmTC_1858b.dir/build.make:81: CMakeFiles/cmTC_1858b.dir/testCCompiler.c.o] Error 2
          gmake[1]: Leaving directory '/pytorch/executorch/extension/llm/tokenizers/build/temp.linux-x86_64-cpython-310/pytorch_tokenizers_cpp/CMakeFiles/CMakeScratch/TryCompile-YqXSLg'
          gmake: *** [Makefile:134: cmTC_1858b/fast] Error 2

The primary CI job of interested, test-vulkan-models-linux / linux-job passed

@SS-JIA SS-JIA merged commit 1164fe4 into main Aug 19, 2025
91 of 105 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/294/head branch August 19, 2025 12:34
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@SS-JIA @agrima1304
[ET-VK][ez] Fix erroneous cherry-pick bot merge (pytorch#13512)
6b5f73b 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ pytorch#13512

Summary:
It seems pytorch#13474 was not merged
correctly via the cherry pick bot. This PR manually syncs internal and
fbcode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SS-JIA @mergennachin